Skip to content

Warn when Syndicate's OSC feedback subscriptions are off - #157

Merged
Skeyelab merged 7 commits into
mainfrom
subs-150
Nov 16, 2026
Merged

Skeyelab merged 7 commits into
mainfrom
subs-150

Conversation

@Skeyelab

Copy link
Copy Markdown
Member

The panel now warns when Syndicate's OSC FEEDBACK subscriptions are off: an orange FEEDBACK ● NO DECK DATA light with help, or a note naming the missing subscription when only some are off.

Closes #150

Core (SubscriptionCheck, Coordinator)

  • Answer window: each Resend opens one. When it closes (feedback_answer_ms, 2 s) in tick(), the Coordinator judges what arrived.
  • noDeckData: set when the answer had no /Deck/* and no /Header/* value (cos's guard: Syndicate sends nothing for an empty deck, so header data proves the subscriptions are on). Any deck or header value clears it, at any time.
  • missingSubscriptions: the LED groups a deck that reported Loaded 1 lacked in that answer: Playing, Cues, Sync, Loop. Empty decks count for nothing.
    • PlayPending is left out, since it may only be sent while a play is pending.
  • No false alarms on silence: an unanswered Resend goes stale and flags nothing. A later complete answer clears an earlier gap.

Presentation

  • Feedback.noDeckData shows an orange NO DECK DATA light. Quit still asks first, as while LIVE.
  • Help:
    • No deck data: "Syndicate isn't sending deck info. In Syndicate › Settings › OSC FEEDBACK, turn on the subscriptions: …". The list is SetupGuide.subscriptions, so it matches the guide and the README.
    • Partial: e.g. "Hot cue pad colors need the Cues subscription. Turn it on in Syndicate › Settings › OSC FEEDBACK." Several are named in one sentence.
    • A controller that needs a hand comes first.
  • Sync test: every Core Subscription maps to a name in SetupGuide.subscriptions.

App

  • The status copies noDeckData and missingSubscriptions from the Coordinator.
  • The panel maps them to the new state.
  • New snapshots feedback-no-deck-data and feedback-cues-missing. I checked both.

Checks

  • All tests are test-first, with literal expectations.
  • After merging main, 367 tests pass and the local Release build succeeded.
  • I didn't run smoke locally.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VCgWWsdAAQXJWYmYEXyTy7

Skeyelab and others added 7 commits November 16, 2026 00:00
Refs #150

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCgWWsdAAQXJWYmYEXyTy7
Only a deck that reported Loaded 1 counts: Syndicate sends nothing for an
empty deck.

Refs #150

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCgWWsdAAQXJWYmYEXyTy7
The warning's subscription names come from the setup guide's list, so the
guide, the README and the warning stay in step.

Refs #150

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCgWWsdAAQXJWYmYEXyTy7
Closes #150

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCgWWsdAAQXJWYmYEXyTy7
@Skeyelab Skeyelab added this to the v1.0: native Mac app milestone Nov 16, 2026
@Skeyelab
Skeyelab enabled auto-merge November 16, 2026 05:03
@Skeyelab
Skeyelab merged commit 59aac3c into main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn when Syndicate's OSC feedback subscriptions are off

1 participant